Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support to optional function errorsCheck and parseAndHandleHttpResponse #5

Conversation

pragmaticivan
Copy link
Contributor

It also adds peer dependencies as dev dependencies for local development.

…eHttpResponse

errorsCheck throws errors by default if available.
parseAndHandleHttpResponse throws error by default if there's a problem with http response.
@pragmaticivan pragmaticivan requested a review from jkusachi March 27, 2019 21:30
@jkusachi
Copy link
Owner

Looks good! ill merge it

in a follow up commit can you add a README entry? when free

Copy link
Owner

@jkusachi jkusachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jkusachi jkusachi merged commit 11b3a8d into jkusachi:master Mar 27, 2019
@jkusachi
Copy link
Owner

will be released on v1.1.0

@jkusachi
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants